Update everything to ES6 and adopt a code style by facekapow · Pull Request #120 · runtimejs/runtime

facekapow · 2016-07-08T18:59:40Z

This PR is a big one, it changes pretty much all of the JavaScript files, since it updates everything to ES6, plus adopts airbnb/javascript as a code style (with a few tweaks, like using require instead of ES6 modules).

Done so far:

…x.js, js/version.js, js/__loader.js, switch airbnb eslint config

vitkarpov · 2016-07-08T19:27:30Z

Goodbye commit history :)

facekapow · 2016-07-08T21:08:46Z

Also added guidelines for contributing, plus a list of exceptions to Airbnb's style guide.

RossComputerGuy · 2016-07-08T21:35:30Z

How do we update runtime with npm.

…o code-style

…t/*.js

facekapow · 2016-07-20T13:06:42Z

This is done and ready for review/merge, the only thing I'm not really confident about is the CONTRIBUTING.md. I've got some more node compatibility fixes, but I'd prefer to add them in another PR after this has been merged to avoid any conflicts.

iefserge · 2016-07-21T22:54:08Z

This is awesome, I'll do some tests too, to make sure everything works.

iefserge · 2016-07-23T05:32:27Z


-function readHostname(reader) {
-  var labels = [];
+const readHostname = (reader) => {


I think regular function declarations are fine, stack trace will be nicer

iefserge · 2016-07-23T14:13:25Z

  if (!dev.writeGuestFeatures(features, driverFeatures, deviceFeatures)) {
-    debug('[virtio] driver is unable to start');
-    return;
+    return debug('[virtio] driver is unable to start');


nitpick, it shouldn't return debug() return value

facekapow · 2016-07-24T22:16:34Z

Ok, I've update the code to only use arrow functions for property functions and callbacks and function declarations for everything else, I've run the code through a beautifier, removed the newlines in js/__loader.js, used spaces instead of newlines in js/core/pci/scan.js, readded eslint-plugin-runtime-internal, disabled no-use-before-define for functions, and fixed the other issues you mentioned.
And I tested it and it still works.

iefserge · 2016-07-25T10:22:00Z

 const { MACAddress, Interface } = runtime.net;

-const virtioHeader = (() => {
+const virtioHeader = (function () { // eslint-disable-line wrap-iife


nitpick, arrow function if ok in this case?

facekapow · 2016-07-25T12:32:16Z

Converted IIFE functions to arrow functions, and fixed the minor style issues. Sorry, most of these little things are because of the beautifier I ran it through.

iefserge · 2016-07-25T21:05:24Z

-    socket._transmit = recvACKFIN;
-    socket.close();
-    t.equal(socket._state, tcpSocketState.STATE_TIME_WAIT);
+    socket._transmit = recvACKFIN; socket.close(); t.equal(socket._state, tcpSocketState.STATE_TIME_WAIT);


single line?

iefserge · 2016-07-25T21:07:23Z

@facekapow left couple of places where there are a few statements on the single line.

facekapow · 2016-07-25T21:17:41Z

@iefserge Well, that's the last time I use a beautifier 😄

iefserge · 2016-07-28T23:14:26Z

LGTM
great work 👍

kesla · 2016-07-29T00:10:54Z

wow. Amazing.

facekapow · 2016-07-29T13:21:57Z

Great, then I'll just do a quick once-over on the code and merge.

facekapow · 2016-07-29T15:51:22Z

Everything looks ok, I tried to run the JS tests, but those are definitely broken (more specifically, tape kept complaining about Stream), but I did some manual feature testing and everything looks fine. Merge?

vitkarpov · 2016-07-29T16:12:07Z

bye-bye history of changes :)

iefserge · 2016-07-29T16:17:12Z

@facekapow yeah, I've been looking into tests issue, should be fine, going to fix it afterwards.
@vitkarpov yeah, but consistent and nice code style is good :)

Face Kapow added 4 commits July 8, 2016 11:32

Move .eslint* to root, lint & ES6 js/components/dns-client/*, js/inde…

b15b6ca

…x.js, js/version.js, js/__loader.js, switch airbnb eslint config

lint & ES6 js/core/*.js, js/core/debug

ee0f018

lint & ES6 js/core/keyboard, js/core/pci

a5f3cbb

lint & ES6 js/core/ps2, js/core/random, js/core/stdio, js/core/tty

48551dd

facekapow added 4 commits July 8, 2016 15:31

Add a CONTRIBUTING.md

3581837

Create code-style-exceptions.md

fa76575

Add feature request section, update link to code style exceptions

a7d0f73

Fix typo, add a note, add some extra wording

a876725

Face Kapow added 10 commits July 9, 2016 07:44

js/driver/ps2, js/driver/virtio/*.js, ignore consistent-return

9e61164

Merge branch 'code-style' of https://github.com/runtimejs/runtime int…

0153164

…o code-style

js/driver/virtio/vring

a320c6f

js/modules, fix 'self', change some of the wording in the docs

2178210

js/service/*, js/utils

fecb02e

js/test/unit/buffers, js/test/unit/lib, js/test/unit/net, js/test/uni…

ae461ee

…t/*.js

everything except js/core/net

f94b97b

Finish linting! 🎉

0562cb0

Code fix

7c16016

Code fix (again)

c8d8fd0

facekapow changed the title ~~Update everything to ES6 and adopt a code style - WIP~~ Update everything to ES6 and adopt a code style Jul 17, 2016

facekapow mentioned this pull request Jul 22, 2016

Using WebAssembly? #111

Open

iefserge reviewed Jul 23, 2016
View reviewed changes

Update style

51a90e7

facekapow added 2 commits July 24, 2016 22:46

Update .eslintrc

0cc5b4d

Update code-style-exceptions.md

dd1c074

iefserge reviewed Jul 25, 2016
View reviewed changes

IIFE function -> IIFE arrow function, fix style issues

9e7368e

iefserge reviewed Jul 25, 2016
View reviewed changes

Fix some more style

a6241b0

facekapow merged commit 7299d5e into master Jul 29, 2016

facekapow deleted the code-style branch July 29, 2016 18:49

Conversation

facekapow commented Jul 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vitkarpov commented Jul 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facekapow commented Jul 8, 2016

Uh oh!

RossComputerGuy commented Jul 8, 2016

Uh oh!

facekapow commented Jul 20, 2016

Uh oh!

iefserge commented Jul 21, 2016

Uh oh!

iefserge Jul 23, 2016

Choose a reason for hiding this comment

Uh oh!

iefserge Jul 23, 2016

Choose a reason for hiding this comment

Uh oh!

facekapow commented Jul 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iefserge Jul 25, 2016

Choose a reason for hiding this comment

Uh oh!

facekapow commented Jul 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iefserge Jul 25, 2016

Choose a reason for hiding this comment

Uh oh!

iefserge commented Jul 25, 2016

Uh oh!

facekapow commented Jul 25, 2016

Uh oh!

iefserge commented Jul 28, 2016

Uh oh!

kesla commented Jul 29, 2016

Uh oh!

facekapow commented Jul 29, 2016

Uh oh!

facekapow commented Jul 29, 2016

Uh oh!

vitkarpov commented Jul 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iefserge commented Jul 29, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

facekapow commented Jul 8, 2016 •

edited

Loading

vitkarpov commented Jul 8, 2016 •

edited

Loading

facekapow commented Jul 24, 2016 •

edited

Loading

facekapow commented Jul 25, 2016 •

edited

Loading

vitkarpov commented Jul 29, 2016 •

edited

Loading